Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet post allow no for broadcast flag #3635

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Conversation

ygao76
Copy link
Contributor

@ygao76 ygao76 commented Mar 10, 2023

Summary

Allow offline post transaction without broadcast

 yarn start wallet:post --help
yarn run v1.22.19
$ yarn build && yarn start:js wallet:post --help
$ tsc -b
$ cross-env OCLIF_TS_NODE=0 IRONFISH_DEBUG=1 node --expose-gc --inspect=:0 --inspect-publish-uid=http --enable-source-maps bin/run wallet:post --help
Post a raw transaction

USAGE
  $ ironfish wallet:post [TRANSACTION] [-v] [--config <value>] [-d <value>] [--rpc.tcp] [--rpc.ipc] [--rpc.tcp.host <value>] [--rpc.tcp.port <value>] [--rpc.tcp.tls] [--rpc.auth <value>]
    [--account <value>] [--confirm] [--broadcast]

ARGUMENTS
  TRANSACTION  The raw transaction in hex encoding

FLAGS
  -d, --datadir=<value>   [default: ~/.ironfish] The path to the data dir
  -v, --verbose           Set logging level to verbose
  --account=<value>       The account that created the raw transaction
  --[no-]broadcast        Broadcast the transaction after posting
  --config=<value>        [default: config.json] The name of the config file to use
  --confirm               Confirm without asking
  --rpc.auth=<value>      The RPC auth token
  --rpc.ipc               Connect to the RPC over IPC (default)
  --rpc.tcp               Connect to the RPC over TCP
  --rpc.tcp.host=<value>  The TCP host to listen for connections on
  --rpc.tcp.port=<value>  The TCP port to listen for connections on
  --[no-]rpc.tcp.tls      Encrypt TCP connection to the RPC over TLS

DESCRIPTION
  Post a raw transaction

  Use this command to post a raw transaction.
  The output is a finalized posted transaction.

Testing Plan

yarn start  wallet:post 01000000000000000100000000000000a8053f85f8103e8cb96c6c0c7dae45826d9bab350a6753be4534bc191b760f166dd7c86706f5817aa718cd1cfad03233bcd64a7789fd9422d3b17af6823a7e6ac600800eb4e0eb0e00334182218061b646f6f4172aec2a92cb7ae7f4ca910639b51b524406129b440147656e6573697320426c6f636b00000000000000000000000000000000000000f9f37b7fca2aa5440d429dba7a00aaa2210a0da8090f8606c56a9baf86bd0ac7030000000000000020c971e61a65df4c334ea1eaa2dbec11be37ae99c818e3b42db2c9800e837eda3920000000000000000020677f865633af7b434a6d3ff3868f05b73a3d99596c9bbc327b464c73879cdd560120333b8f73a38aeed8ae2a4ec8d4135d9dd17ef999263e0a9b3d8be19dfbc8453e0020e5913f4e817be9ffb1ff4b010d5e3f7e8dc6ed8e1ebed9d12348a67f39ee3304002026da64f9d8fe689db938c1d540a19c812c88c4089692d3e93da6c110d66f8a6000203d0cf248407ff2b678cf8c5aac0e477556a687116683e4e94f26c0e23921e95d0020879b92fce4e56ef0ce31ee8b9ff127abbc9234e79c6a4730a60b25b1228682090020044fb2205ca6e5f3d2c00be06df8dee6f30efa06df63ddca9dc905282b72f35f002076e08cb05c13284f5fdf388711efda84499ac12374b19c37b103dd0c4ed90e1c00204ca54320f97e8cac51e5b9920a760f3a4e86c22d19685bd12fc7b69a9261646300207db3e92e1ec464f703088a69d23d6f815240d60f20deb7cbe761d4442c18ff690020d7684ccff15912c47b190dd38e82e37bbf720a94d6812e3f2435c0d8cfb8cf600020cd3e4b4a0791f16a63151fb97ffcb21e3e8d02cb03e13251342c1f3837e15c4e00202f877db14b6bb06b726da26c904b5499ea41b7ae4efd9fbd26fdfdaf5fe896280020b211bdabf8543535f0b1cfd7f34cc3f43a6b438d64619e1cd55753a5e4f4f82a0020e88c013d440557a456909c051118bbe7d247d65371a3be4f0eaf81ea02945816002086493829ce53dd735b2009bcb758accce5fcadbbe461f7ab4053354f7370ad280020c8a4f86e5af862153a396b52ca90431b935aeae6656e08b88090d598dfd1004400202f38bc5d2fa294edc0c472393b7802eec5dfd720697de89c4f04757cfbcb4c630020260b6dba4d2cec598fc1fb6522e5867f14974c7ce33f38260311ede65d3b493d0020c0f6238fd5f5e3330324426a4328d4468102faee2b9170b562cce7d3f3c30e3600207e78a57f3435a57077639e594f191416c77ed8adcbdd0211a2782906749b47590020286461a5c2dc87c1aecf382f889b8c6e4ccd8ff17330ea043d0df423be141a090020039b5febe4d7a7d8bd59c4ad7c2e882b661d1d0d04a7e3734cb59bb6719f7c4b0020f4667b4d55afb10445404bfec22bbefa767b6d4d3e7d6dddfbd3287d1d331d14002068c0f13b06a1cddac5673d25298fccf10af99520f344779961d847fb2003982900205531693ebac4028ca711a4141830e1585ef0ef907da34cf4ccc9e79880b98444002077fcc3e8456d7e0e87555ec99c581e8eba901c5b8021b202da49d85cf44690450020ed9c6e8ef5edc406eb41cf4ebcb4ca81ca18b1fdb202a19134e0fecd907cf84500201a58de42b76c01d399454a33029a4a00d67f25d1e061c128bad7b1aa8cc2e05e0020ac323db9096fdc647e6c2ab04fe500319621be4cc8c63373957946b92ed1874d00203d643214bb612e41b28a751764ef3edc447da92288d7d87b87a0d67936a23219002012ab3373d3740e14bb955faff5986e5a050941d49cbfedf90c381a8e4dc4b1030100000000000000a80e0e42628ae521b5971b6a6c0384e41a623e6332249f86ef080184440d5e0840d7c86706f5817aa718cd1cfad03233bcd64a7789fd9422d3b17af6823a7e6ac600e1f50500000000588cda2a47dd00dc14dd994a31963b9f1febd43835080852aa9f88d527f99f070000000000000000000000000000000000000000000000000000000000000000053f85f8103e8cb96c6c0c7dae45826d9bab350a6753be4534bc191b760f166d000000000000000000000000000000000110000000 --account IronFishGenesisAccount '--datadir=~/.ironfish-1' --no-broadcast
You are about to post a transaction that sends $IRON 1.00000000, with 0 mints and 0 burns with a fee $IRON 0.00000001 using account IronFishGenesisAccount
Do you want to post this (Y/N)?: Y
Posting the transaction... done
Posted transaction with hash 3c1756b1972953dc70caab88fc5bd20ed3e4c79d4a818a13c41ec8493b5881cb

01010000000000000002000000000000000000000000000000000000000000000001000000000000001000000017517b6a21a7ae05c73cf5812d30a9cd12bf54186b1a3b0e939ddca4499f7a84b5b228ee858189a37eb8cd7cd29220b8314603b6605b6ab7bc6994741ab3b9ffe3754b4dad81ecfc7a106cde07e6075bb9d21c4d0c11d644979be7fe0e07e2a9fa83438dc11d2c3c28040feee2a6d6d812cd158613eadf1be6b9b40ceaae1a3e0066af6d70af925050bc317f96cb8fa9982d4f19c3dceae4ce6cc3bc219d081b4257598666fbbb7d2afae648ac9fd05fb219d74eaf533e564c68d5fad9e1ed5122f098b31ab0124ed39a9c2d65c7aec0b3ed96cd6c3d67360d127d07680573a72faa27d09f07b7686c0c15aba31b3353cbe12b1d0ad8eae97450b2229339ca6fc971e61a65df4c334ea1eaa2dbec11be37ae99c818e3b42db2c9800e837eda3903000000b6660304867d13b8c9153d5974e7769c86d446e925c6a082cfa0da1fc50f677d222bc15c7ebc2c1aaa7eacd3bae1e5b2de1a0a4863779da6acdfc1758879baa3601b0d446796517674b1feadf5a3afb81599c5497ceef0dd6ec07f897c8f0a0d8b2bf2bd2da1a70cc0b38a53f6a03efe0161c663042070de4ef64b363358a93e7f6877c616cea73aa6ba01b3fa9acdf69148c1f5e54cd2216024965da4122839daac20b0524465c04985dd78aa3e462ae732aba7315d743f25413956511a936109a8277eadd4913a5f1446c0559546e935e4c661cddb850a4a14926675fe38a49a55d39f80b4f4b1a5878d387ce0c814a0059160d2a227f0058a5c4695dcd0721cd73a2c111f1a246a66077790e021e77b5f36242b59325cba899f55156fb50e9089f8dde7368d4e75cca51702df192079e74484b9083264843369d6c762ddc46672efbf5c585f0fde7298dc5996acf4d3151c1d72c536ef884ff004b8dfed200820cdf67c18c94e5f36d6264a754a8479ee49befe9412f39684f86317466f449a3b4ba84a93f90e567186c510b023a043bdcb6e4248d0f2fb263f12d71f932dff0c5999aea420ba201f0b61bfa9c69a7da9b47be4fc486db5474abbb33a1aef20f9376b55d8558c2394d94c2c0b1ebfc8ef4f4e0be7c82fdf3b8bd425c9dd0b90f9f7168cbf7458565664f004b2b15bfe88449552a129cec4757d0df43c0d342e277edc3d600605160d92a97e984c8573a59dc3a0b9164480284f0433890807b950bf0d2d4c9bb30e170fbe45da56e777a295600c39b4ec8b2b37283af8e0a984bef5734bb9babd9b685a8d16cc155dc6b3eea5cbe6a29267cb03cf298f079c2554767b9fd03031ac82d431ddf31ff40f2d50772066fc4f71cb394dacda330991990d4ddddd1e17912af356e9b7ad94b5e835a4ce134d83948da03d09a1da52e6a533b15c2b106147a5f659c8f8dbb878ea996a7ef15e8207b86eaabf45637ac188b1d0d000ce0e0a8ad9fc746003d45d12a7f75a084b561d955ab0d88ad123516a8ca6017977bacfc389f2c9208ea458ea42f59e107c0990fe0b357894ec9406e16ec0e3236578baa9975d24c2a6afa52f8abbcaf7c65b23cd15054b54f6101cc70934f0b1827f79e872f5127b31252d7e6a788af2b04403b954fd9d7053f726192b3f3d9874491a4aa70d8827cb373f6d982edb5d4eb975f4dd06a528e0533e62e40c65b4b635fb86b6aadcacadb871a385148e51fbeb8a528beead00c89c02bc28e9a285b3e535327d91ad4a602429b39d4ba11afeec395991ed14c407b3f0d478d558c019f428ca79ea8187f6a2514ef2e20bb99d59bf82114473592e8a283dc19bf621f2a58f5478d6bf23882b41c7af3f8b02c6fa1ea07533e5674bec905eef22feaf6d66a72388c3780d2e5b3cf187c0f010030fcf3ea862c34e3e05b701923fead734a2cb7158a8c418cd1bece0b730abe968d1144e9ec2e40f4a6652f2ee09211563d00401774d7013a98f31fa6ae46ed26366407d13fc9ef75f100f411e7137055039f5f75e5d4c4b724a9c1d57a6b07bf7a0a86bd44f890c5c2c827a75caf4a9fcd6dbccb0fa410415274398afc224c7e44cf30dfd876272bc28656ae53e3aaa4b394c491d66ac9801e7a06849f5a5ae91bda1974c56ebc60e87e9cf67e31489c1ffd85059fb7c097d06

Run "ironfish wallet:transaction:add" to add the transaction to your wallet
✨  Done in 5.63s.

Documentation

Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference
)? If yes, link a
related documentation pull request for the website.

[ ] Yes

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.

[ ] Yes

@ygao76 ygao76 requested a review from a team as a code owner March 10, 2023 02:20
@ygao76 ygao76 merged commit bed07f6 into staging Mar 10, 2023
@ygao76 ygao76 deleted the ygao-wallet-post-fix branch March 10, 2023 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants