updates sync service to submit transaction gossip to api #3926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moves 'syncBlocks' to a separate method defines 'syncTransactionGossip' method to invoke the 'event/onTransactionGossip' RPC and submit transactions to the API updates 'sync' to run both of these methods in coroutines updates 'webApi' with a 'transactions' method. matches transaction serialization with serialization from 'followChainStream' for transactions submitted to API with blocks.
hughy
force-pushed
the
feature/ifl-887/sync-tx-gossip
branch
from
f75ce7d
to
94c8029
Compare
danield9tqh
reviewed
May 26, 2023
danield9tqh
reviewed
May 26, 2023
|
|
||
| async function commit(): Promise<void> { | ||
| await api.transactions(buffer) | ||
| buffer.length = 0 |
There was a problem hiding this comment.
does this actually clear the buffer? Never seen this before. I guess that's what it was in the block code before
There was a problem hiding this comment.
yeah this looks a bit odd 🤔
copied from the existing syncer code, but i'll take a closer look
There was a problem hiding this comment.
This will clear the array without replacing it: https://stackoverflow.com/a/1232046
|
Looks mostly good to me. I think we can test this on the testnet first for integration testing |
danield9tqh
approved these changes
May 26, 2023
jowparks
pushed a commit
that referenced
this pull request
Jun 21, 2023
* updates sync service to submit transaction gossip to api moves 'syncBlocks' to a separate method defines 'syncTransactionGossip' method to invoke the 'event/onTransactionGossip' RPC and submit transactions to the API updates 'sync' to run both of these methods in coroutines updates 'webApi' with a 'transactions' method. matches transaction serialization with serialization from 'followChainStream' for transactions submitted to API with blocks. * reuses client between sync methods * adds expiration to api transaction writes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
moves 'syncBlocks' to a separate method
defines 'syncTransactionGossip' method to invoke the 'event/onTransactionGossip' RPC and submit transactions to the API
updates 'sync' to run both of these methods in coroutines
updates 'webApi' with a 'transactions' method. matches transaction serialization with serialization from 'followChainStream' for transactions submitted to API with blocks.
Testing Plan
manual testing: ran syncer locally and synced transaction to testnet api: 5c1fa0c851957d46585addf64567fb6ab93f980d23d0d698a6ab49cfc2eb7e1b
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.