Rename the ironfish_rust crate to just ironfish
#3946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename the crate in order to better follow the Rust conventions. In particular: https://rust-lang.github.io/api-guidelines/naming.html > Crate names should not use -rs or -rust as a suffix or prefix. Every > crate is Rust! It serves no purpose to remind users of this constantly.
mat-if
approved these changes
Jun 5, 2023
andreacorbellini
deleted the
andrea/ifl-1071-rename-the-ironfish_rust-crate-to-just-ironfish
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rename the crate in order to better follow the Rust conventions. In particular: https://rust-lang.github.io/api-guidelines/naming.html
Testing Plan
Rebuilt the repository, and verified that the CLI program starts correctly.
Documentation
N/A
Breaking Change
Not a breaking change (yet) thanks to the fact that
ironfish_rustis not public.