Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move chain db size out of telemetry class and into stats cmd #3954

Conversation

ygao76
Copy link
Contributor

@ygao76 ygao76 commented Jun 7, 2023

Summary

Move chain db size to stats cmd
Add chain db size to node getStatus response
Remove chain db size from telemetry class and blockchain class

Testing Plan

locally run yarn start service:stats
log chain db size to console

yajun@Yajuns-MBP ironfish-cli % yarn start service:stats
yarn run v1.22.19
$ yarn build && yarn start:js service:stats
$ tsc -b
$ cross-env OCLIF_TS_NODE=0 IRONFISH_DEBUG=1 node --expose-gc --inspect=:0 --inspect-publish-uid=http --enable-source-maps bin/run service:stats
module: @oclif/core@1.23.1
task: toCached
plugin: ironfish
root: /Users/yajun/ironfish/ironfish/ironfish-cli
See more details with DEBUG=*
(Use `node --trace-warnings ...` to show where the warning was created)
chain DB size 3486947512

Documentation

Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference
)? If yes, link a
related documentation pull request for the website.

[ ] Yes

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.

[ ] Yes

@dguenther

@ygao76 ygao76 requested a review from a team as a code owner June 7, 2023 19:36
Copy link
Member

@dguenther dguenther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! For documentation, this will require an update to https://ironfish.network/developers/documentation/rpc/node/get_status once it's released, so you could prepare a draft PR with the changes for when that happens

Copy link
Member

@dguenther dguenther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! For documentation, this will require an update to https://ironfish.network/developers/documentation/rpc/node/get_status once it's released, so you could prepare a draft PR with the changes for when that happens

@ygao76 ygao76 merged commit e96304b into staging Jun 7, 2023
3 checks passed
@ygao76 ygao76 deleted the yajun/ifl-1086-move-chain_databasesize-out-of-telemetry-class-and-into branch June 7, 2023 23:49
jowparks pushed a commit that referenced this pull request Jun 21, 2023
* Move chain db stat to stats cmd

* Add chain db to node getStatus reponse
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants