Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to rename accounts in a wallet #3955

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Add functionality to rename accounts in a wallet #3955

merged 1 commit into from
Jun 13, 2023

Conversation

andreacorbellini
Copy link
Contributor

@andreacorbellini andreacorbellini commented Jun 7, 2023

Summary

Added a new RPC endpoint to rename accounts, and the corresponding CLI command.

Testing Plan

CLI:

$ ironfish wallet:create test-1
Creating account test-1
Account test-1 created with public address ...

$ yarn start wallet:accounts
default
test-1

$ yarn start wallet:rename test-1 test-2
Account test-1 renamed to test-2

$ yarn start wallet:accounts
default
test-2

RPC:

$ curl -s http://127.0.0.1:8021/wallet/getAccounts
{"status":200,"data":{"accounts":["default","test-1"]}}

$ curl -s http://127.0.0.1:8021/wallet/rename --json '{"account":"test-1","newName":"test-2"}'
{"status":200}

$ curl -s http://127.0.0.1:8021/wallet/getAccounts
{"status":200,"data":{"accounts":["default","test-2"]}}

Documentation

iron-fish/website#459

Breaking Change

Not a breaking change

- added the `wallet/rename` RPC endpoint
- added the `wallet:rename` CLI command
@andreacorbellini andreacorbellini merged commit ab5e3ec into iron-fish:staging Jun 13, 2023
3 checks passed
@andreacorbellini andreacorbellini deleted the andrea/ifl-829-allow-renaming-accounts-in-a-wallet branch July 28, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants