Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies to fix vulnerabilities found by yarn audit #3956

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Update dependencies to fix vulnerabilities found by yarn audit #3956

merged 1 commit into from
Jun 9, 2023

Conversation

andreacorbellini
Copy link
Contributor

@andreacorbellini andreacorbellini commented Jun 8, 2023 •
edited

Summary

yarn audit found 49 high-severity and 3 moderate-severity vulnerabilities in our dependencies (see IFL-1093 for details). This PR updates them all.

These changes are the result of a mix of using npx yarn-audit-fix, and manually fixing the @aws-sdk dependency versions.

Testing Plan

  • yarn audit reports no problem
  • node can start and operating correctly
  • tests pass successfully

Documentation

N/A

Breaking Change

N/A

@andreacorbellini andreacorbellini requested a review from a team as a code owner June 8, 2023 20:26
mat-if
mat-if approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@mat-if mat-if left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change diff makes this PR look a lot scarier than it is - looking at the yarn.lock, it all seems pretty minor besides the AWS dependency churn 🙌

@andreacorbellini andreacorbellini merged commit 511cd28 into iron-fish:staging Jun 9, 2023
3 checks passed
@andreacorbellini andreacorbellini deleted the andrea/ifl-1093-fix-vulnerabilities-found-by-yarn-audit branch July 28, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mat-if mat-if mat-if approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andreacorbellini @mat-if @andiflabs