Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent accidental publishing of crates that are not meant to be publ… #3957

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Prevent accidental publishing of crates that are not meant to be publ… #3957

merged 1 commit into from
Jun 8, 2023

Conversation

andreacorbellini
Copy link
Contributor

Summary

Added publish = false to internal crates that are not meant to be published, to prevent accidental publishing.

The only crates that don't have publish = false are ironfish and ironfish_zkp.

Testing Plan

cargo publish --dry-run -p benchmarks (and similar for other crates) should fail with:

error: `benchmarks` cannot be published.
`package.publish` is set to `false` or an empty list in Cargo.toml and prevents publishing.

Documentation

N/A

Breaking Change

N/A

@andreacorbellini andreacorbellini requested a review from a team as a code owner June 8, 2023 20:52
@andreacorbellini andreacorbellini merged commit 08d0309 into iron-fish:staging Jun 8, 2023
11 checks passed
@andreacorbellini andreacorbellini deleted the andrea/prevent-cargo-publishing branch July 28, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants