refactor(ironfish-rust): Introduce download-params feature-flag #3961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mat-if
changed the title
Due to the reqwest dependency during build, anyone building the ironfish crate was required to have openssl available via the system, even if they were not downloading the params. This was causing issues with the build system, and is not a trivial fix in some scenarios. This change marks the `reqwest` dependency as optional, which is only installed if the `download-params` feature-flag is set. The default behavior is, for now, to crash if no params are present.
EvanJRichard
approved these changes
Jun 12, 2023
jowparks
pushed a commit
that referenced
this pull request
Jun 21, 2023
) Due to the reqwest dependency during build, anyone building the ironfish crate was required to have openssl available via the system, even if they were not downloading the params. This was causing issues with the build system, and is not a trivial fix in some scenarios. This change marks the `reqwest` dependency as optional, which is only installed if the `download-params` feature-flag is set. The default behavior is, for now, to crash if no params are present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Due to the reqwest dependency during build, anyone building the ironfish
crate was required to have openssl available via the system, even if
they were not downloading the params. This was causing issues with the
build system, and is not a trivial fix in some scenarios.
This change marks the
reqwestdependency as optional, which is onlyinstalled if the
download-paramsfeature-flag is set. The defaultbehavior is, for now, to crash if no params are present.
Testing Plan
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.