Support a minimum of NodeJS v18 #4395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since NodeJS LTS version was just bumped to v20, we need to support it properly. - Bumps any minimum versions of 16 to 18 - Allows the CLI and the main entrypoint to support 18 _or higher_ - Update install instructions to simply reference latest LTS version so we can avoid manually bumping it all the time
danield9tqh
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since NodeJS LTS version was just bumped to v20, we need to support it properly.
Testing Plan
Tested running a node on NodeJS 18 and 20
Documentation
iron-fish/website#561
Breaking Change
We are removing NodeJS 16 support. This was only semi-supported in the first place so it should not be a huge change, but is worth noting.