Upgrade Node.js version to 16 #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IRO-733 Upgrade Node version to Node 16
I think the upgrade should be as simple as changing the version in the CLI, but upgrading the Docker + Homebrew packages, READMEs, and informing the community (for those installing from source) will take more time. |
NullSoldier
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades Node.js to the latest LTS, version 16.
I tested this on an M1 Mac Mini and it seems to build and run fine. However, our Homebrew workflow needs to be updated, probably to use bottles, because the current version assumes x86 when uploading the build artifacts. So we can't yet remove the platform check script forbidding Apple Silicon from running.