fix: delete of account via RPC throws while node account rescan is active #4867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jowparks
force-pushed
the
fix-rescanning-account-crash-delete
branch
from
824b3f1
to
72684f6
Compare
…ror was that in memory store still contained account for a moment while the head was deleted.
jowparks
force-pushed
the
fix-rescanning-account-crash-delete
branch
from
72684f6
to
8dbe40a
Compare
hughy
approved these changes
Apr 3, 2024
jowparks
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr: when called delete account on a node that is rescanning, head is deleted for the account before it is deleted from in memory store of
wallet.accounts.Problem
RPC Client - delete account sent to remote node. Occasionally, node will crash saying head isn't set.
RCA:
Order of events that cause failure:
this.accounts.delete(account.id)is not yet called.connectis called,wallet.accountsstill contains account created from step 1/2.Testing Plan
Manual testing, difficult to reproduce.
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with
breaking-change-rpcorbreaking-change-sdk.