Use new render function in the CLI #4880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danield9tqh
reviewed
Apr 9, 2024
| confirmations: flags.confirmations, | ||
| }) | ||
| ).content | ||
|
|
||
| const assetId = response.content.assetId | ||
| const assetName = renderAssetName(isNativeIdentifier(assetId) ? '$IRON' : assetId, { | ||
| let nameToRender |
There was a problem hiding this comment.
Do you think we should re-use this functionality in CurrencyUtils?
danield9tqh
reviewed
Apr 9, 2024
| @@ -40,11 +40,17 @@ export async function promptCurrency(options: { | |||
| if (options.balance) { | |||
There was a problem hiding this comment.
We should also be changing CurrencyUtils.decodeIronTry(input)
danield9tqh
reviewed
Apr 9, 2024
| @@ -124,9 +124,13 @@ export async function selectAsset( | |||
| const choices = balances.map((balance) => { | |||
There was a problem hiding this comment.
We should
- give verified status when selecting an asset
- put verified assets at top of list
(can do in future PR)
danield9tqh
reviewed
Apr 9, 2024
| @@ -116,13 +116,10 @@ export class PostCommand extends IronfishCommand { | |||
| spending += output.note.value() | |||
| } | |||
|
|
|||
| const renderedSpending = CurrencyUtils.render(spending, true) | |||
There was a problem hiding this comment.
Remember to change this command to not just sum up all outputs as if they are IRON. Filed a ticket for later
danield9tqh
reviewed
Apr 9, 2024
danield9tqh
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use the new currency render function in the CLI. See #4879 for more information about that function
Testing Plan
Manual testing
Documentation
N/A
Breaking Change
N/A