Put miner's fee transaction first on blocks #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullSoldier
reviewed
Dec 1, 2021
NullSoldier
reviewed
Dec 1, 2021
NullSoldier
approved these changes
Dec 1, 2021
Co-authored-by: Jason Spafford <nullprogrammer@gmail.com>
NullSoldier
added a commit
that referenced
this pull request
Dec 1, 2021
* Put miner's fee transaction first on blocks * Update ironfish/src/mining/director.test.slow.ts Co-authored-by: Jason Spafford <nullprogrammer@gmail.com> * Fix lint * Fix typo * Fix test failure Co-authored-by: Jason Spafford <nullprogrammer@gmail.com>
NullSoldier
added a commit
that referenced
this pull request
Dec 1, 2021
* Put miner's fee transaction first on blocks * Update ironfish/src/mining/director.test.slow.ts Co-authored-by: Jason Spafford <nullprogrammer@gmail.com> * Fix lint * Fix typo * Fix test failure Co-authored-by: Jason Spafford <nullprogrammer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added some code a while ago to always put the miner's fee transaction first on a block, but didn't test it sufficiently, so actually it was ending up at the end (but block.minersFee was still returning the first transaction). This branch fixes the order so that the miner's fee transaction always comes first, and is checked by the verifier
This will require a network reset.