chore: add graffiti logging on start #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullSoldier
approved these changes
Dec 22, 2021
|
This is great, thank you. |
NullSoldier
pushed a commit
that referenced
this pull request
Dec 22, 2021
dguenther
added a commit
that referenced
this pull request
Jan 4, 2022
* Use nullifier tree size to verify spend (#798) We were using the notes tree size to verifier the spend, which is not correct but shouldn't generally cause an issue because the note tree is bigger than the nullifier tree. * Fix use of clearLine in miners:mined (#816) * chore: add graffiti logging on start (#818) * Set default expiration delta to 15 from 450 (#822) * Use @napi-rs/blake-hash instead of blake3 (#815) The blake3 package doesn't seem to ship a native addon that works properly in node 16, so let's try blake-hash instead. * Optimize MerkleTree.contains from O(n) to O(1) (#775) * In merkletree's contained & contains method we had a horribly inefficient linear scan which brought up avg time to add a block with multiple transactions to multiple seconds making syncing painfully slow. This change introduces another db store to keep track of merkle tree elements for O(1) retrieval if the element is in the tree or not. * removing pastSize from the contained method * Use existing merkle hash * Fix dead lock * Minor cleanup inside of verifier (#811) * Rename hasValidSpends to verifyConnectedSpends (#809) * Only verify spend root in hasValidSpends (#810) * Truncate index during MerkleTree truncate (#820) Co-authored-by: NullSoldier <nullprogrammer@gmail.com> * Bump version to 0.1.15 * Update docker-compose configurations * Fix path and change services name * Fix readme * Add volume to miner service * Proofreading Docker.md Co-authored-by: Jason Spafford <nullprogrammer@gmail.com> Co-authored-by: Derek Guenther <derek@ironfish.network> Co-authored-by: jintao <cdv1013@gmail.com> Co-authored-by: Elena Nadolinski <elena@ironfish.network> Co-authored-by: Rohan Jadvani <5459049+rohanjadvani@users.noreply.github.com> Co-authored-by: Derek Guenther <dguenther9@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add graffiti log on start
Testing Plan
I run it doggy
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.