Fix overly large faucet fee #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullSoldier
approved these changes
Jan 11, 2022
rohanjadvani
approved these changes
Jan 11, 2022
NullSoldier
pushed a commit
that referenced
this pull request
Jan 14, 2022
* Use length of pending faucet transaction payload instead of max allowable count * Rename count to maxPossibleRecipients
NullSoldier
pushed a commit
that referenced
this pull request
Jan 15, 2022
* Use length of pending faucet transaction payload instead of max allowable count * Rename count to maxPossibleRecipients
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changed fee multiplier to use the length of the faucet transaction payload instead of the count used to query the API to get multiple faucet requests. Prior to this change, it resulted in faucet transactions paying out 50 $ORE (as 50 is our current internal limit) instead of X $ORE where X is the amount of faucet requests being fulfilled.
Testing Plan
Tested manually.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.