Fix transaction withReference and use in followChain #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullSoldier
reviewed
Jan 12, 2022
NullSoldier
reviewed
Jan 12, 2022
|
Investigating test failures on this -- it may end up changing the substance of the PR |
dguenther
force-pushed
the
fix-transaction-reference
branch
from
a64456a
to
c7404fa
Compare
|
All right, tests pass now. |
NullSoldier
approved these changes
Jan 13, 2022
NullSoldier
pushed a commit
that referenced
this pull request
Jan 14, 2022
* Fix transaction withReference and use in followChain * Update failing test
NullSoldier
pushed a commit
that referenced
this pull request
Jan 15, 2022
* Fix transaction withReference and use in followChain * Update failing test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added a
transaction.withReferencearound the transaction use infollowChainto avoid some duplicate deserialization calls.I also noticed that
transaction.withReferencewasn't working correctly for async callbacks -- The callback would execute, then call thefinallyto drop the reference before the callback was finished. Fixed this without makingtransaction.withReferenceasync by creating a separatePromise.resolve()to wrap the result and callingfinallyon that one.Testing Plan
Synced a fresh database locally and also ran a node that was already synced up. Ran followChain with these changes to make sure it still works
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.