service:sync: Only fetch head from API when no head arg #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deekerno
approved these changes
Jan 12, 2022
dguenther
force-pushed
the
change-sync-logs
branch
from
b5d2968
to
bd357ea
Compare
NullSoldier
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
service:synccommand fetches the head from the API, but discards it ifargs.headis set. This PR only fetches the API head if it's going to be used, and adjusts the logs accordingly.This shouldn't change functionality because the code existing code still prioritizes
args.headif it's set.Testing Plan
Ran
service:syncon an existing node withargs.headpassed and withoutargs.headpassed.Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.