feat(ironfish): Add heap and rss gauges to metricsMonitor
#888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullSoldier
reviewed
Jan 13, 2022
deekerno
approved these changes
Jan 13, 2022
NullSoldier
reviewed
Jan 13, 2022
NullSoldier
approved these changes
Jan 13, 2022
* feat(cli,ironfish): Add memory usage to status command * Use memory size utility and create memory field
NullSoldier
pushed a commit
that referenced
this pull request
Jan 14, 2022
* feat(ironfish): Add heap and rss gauges to `metricsMonitor` * Use `SetTimeoutToken` type and `null` type * Create `SetIntervalToken` * feat(cli,ironfish): Add memory usage to status command (#890) * feat(cli,ironfish): Add memory usage to status command * Use memory size utility and create memory field
NullSoldier
pushed a commit
that referenced
this pull request
Jan 15, 2022
* feat(ironfish): Add heap and rss gauges to `metricsMonitor` * Use `SetTimeoutToken` type and `null` type * Create `SetIntervalToken` * feat(cli,ironfish): Add memory usage to status command (#890) * feat(cli,ironfish): Add memory usage to status command * Use memory size utility and create memory field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a
Gaugemetric, and collect RSS / Heap Used metrics every second in the metric monitor.Testing Plan
Manually tested.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.