Remove account and config RPC calls from TCP #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullSoldier
force-pushed
the
tcp-namespace
branch
from
987b30c
to
ac76858
Compare
This removes RPC routes in the accounts and config namespace from being mounted in the TCP adapter. This is to prevent a an attack where users can have their graffiti changed. This is a short term fix because the real fix is to add RPC token authentication. Accessing one of these routes now with TCP will display one of the following errors.
NullSoldier
force-pushed
the
tcp-namespace
branch
from
ac76858
to
1f14ece
Compare
deekerno
approved these changes
Jan 14, 2022
NullSoldier
added a commit
that referenced
this pull request
Jan 15, 2022
This removes RPC routes in the accounts and config namespace from being mounted in the TCP adapter. This is to prevent a an attack where users can have their graffiti changed. This is a short term fix because the real fix is to add RPC token authentication. Accessing one of these routes now with TCP will display one of the following errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This removes RPC routes in the accounts and config namespace from being
mounted in the TCP adapter. This is to prevent a an attack where
users can have their graffiti changed. This is a short term fix because
the real fix is to add RPC token authentication.
Accessing one of these routes via TCP will now display the following error
Testing Plan
Tested lcoally
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.