Make batch size configurable for miner #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kernel32uiuc
force-pushed
the
batchSizeConfig
branch
from
71a5aeb
to
f386e73
Compare
|
Nice addition! I'll do some testing on this then review/merge 🚢 |
NullSoldier
approved these changes
Jan 14, 2022
|
Tested locally, this works. |
NullSoldier
pushed a commit
that referenced
this pull request
Jan 15, 2022
* Make batch size configurable for miner * Default batch size as 10000 * Fix lint errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Playing with batchSize can impact the hash rate. A faster processor can benefit from a higher batchSize. Making it configurable can give more flexibility to miners.
Testing Plan
Manually tested via
When I set a very low batch size, I noticed that the hash rate significantly slows down.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.