Format miner hash rate using metric system #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR wil now format the hash rate in metric increments similar to file sizes while still printing the original value. It also adds tests for the FileUtils, and fixes a few bugs I saw with rounding that produced odd values.
NullSoldier
force-pushed
the
hash-format
branch
from
18a983f
to
25208ac
Compare
deekerno
approved these changes
Jan 20, 2022
ironfish/src/utils/file.ts
Outdated
|
|
||
| const fileSizeSuffix: SizeSuffix = { B: 'B', KB: 'KB', MB: 'MB', GB: 'GB' } | ||
| const memorySizeSuffix: SizeSuffix = { B: 'B', KB: 'KiB', MB: 'MiB', GB: 'GiB' } | ||
| /* This Source Code Form is subject to the terms of the Mozilla Public |
There was a problem hiding this comment.
This was probably unintentional.
dguenther
approved these changes
Jan 20, 2022
NullSoldier
pushed a commit
that referenced
this pull request
Jan 20, 2022
* Add TCP Secure flag to allow secure config over TCP (#908) * Dont set config overrides unless not default value (#910) We found a bug where the base command was setting config overrides for values that are the same as the flags default value. This causes the config file to be ignored. Now, we only set the config override if it's different from the default, which allows the config not to be over-ridden with the flag default. * Fix the Sapling related links (#907) * Move mining logic from NodeJS to Rust (#916) * Move mining logic from NodeJS to Rust * Linter/license cleanup * Fix one more lint check * Add trait to since it already implements it * Change ironfish-cli build dir to ./ from ./src (#915) Need to make this change so we can include package.json in the source * Fix up ChainProcessor and use in Accounts store for processing blocks (#914) * Remove unused name field from chainProcessor * Tag the chainProcessor logger * Throw error if chain processor head not found in chain * Make chainProcessor add/remove private These should only be called inside chainProcessor when updating the head. * Set hash to previousBlockHash when removing blocks * Use chainProcessor in Accounts * Add hashChanged to chainProcessor update * Remove unnecessary test * Fix circular dependency import * Clear the chain processor when resetting accounts Co-authored-by: NullSoldier <nullprogrammer@gmail.com> * Allow version to be driven by lib consumer (#917) This makes a change so that previously, the version sent out everywhere and the agent string was driven by the library. This doesn't tell the full story, because the real version is the person who is consuming the library and potentially writing custom code on top of the library. This lets users who consume the library override the package and produce their own agent and version library using the new Package type that you can produce from a Package.json file and pass down into the node. * feat(cli,ironfish): Show heap total in status and rename RSS to Memory (#918) * feat(cli,ironfish): Show heap total in status and rename RSS to Memory * Fix test * Format miner hash rate using metric system (#921) * Format miner hash rate using metric system This PR wil now format the hash rate in metric increments similar to file sizes while still printing the original value. It also adds tests for the FileUtils, and fixes a few bugs I saw with rounding that produced odd values. * Removed double license * Add debug command with accounts head info (#920) * Add debug command with accounts head info * Add more system info, whether telemetry is enabled * consistent casing and name fix * Update Package usage to match new code * Minor typos in README.md (#919) ## Summary `More details on our documentation` -> `More details in our documentation` And hypenating `command line interface` -> `command-line interface` ## Testing Plan n/a ## Breaking Change Is this a breaking change? If yes, add notes below on why this is breaking and what additional work is required, if any. `Documentation update, not breaking change` * Bump version to 0.1.20 Co-authored-by: mat-if <97762857+mat-if@users.noreply.github.com> Co-authored-by: Andrei Singular/Kitezh <77510705+andreysingular@users.noreply.github.com> Co-authored-by: Derek Guenther <derek@ironfish.network> Co-authored-by: Rohan Jadvani <5459049+rohanjadvani@users.noreply.github.com> Co-authored-by: Ben Holden-Crowther <4144334+blrhc@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR wil now format the hash rate in metric increments similar to
file sizes while still printing the original value. It also adds tests
for the FileUtils, and fixes a few bugs I saw with rounding that
produced odd values.
Testing Plan
Added tests and tested miner locally
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.