Convert native node code from neon to napi-rs #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay, I think this one is ready for review now. I'm going to skim it myself too to make sure nothing unexpected slipped in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
napi-rs has a pretty convenient built-in system for generating prebuilt npm packages for Rust-based modules, plus has other features that would help us out (BigInt support, Promise support, automatically generating TS definitions and JS bindings). Since I'm working on generating prebuilt packages, I wanted to make this change first.
This is pretty likely to fail CI somewhere, so I'm putting this in draft until CI passes.
Testing Plan
I tried generating a transaction, mining, and syncing blocks from another node.
Breaking Change
This shouldn't break compatibility with other versions of the node, but it will require an upgrade of your Rust compiler if building from source.