refactor(ironfish): Clean up existing Telemetry into single service #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullSoldier
reviewed
Feb 10, 2022
|
|
||
| if (points.length < this.MAX_QUEUE_SIZE) { | ||
| this.logger.debug('Retrying telemetry submission') | ||
| this.points = points |
There was a problem hiding this comment.
This needs to be concatted or else you'll wipe out queued points while the request is pending
There was a problem hiding this comment.
Later, we should dump points if we fail after a certain amount of times.
NullSoldier
reviewed
Feb 10, 2022
| export async function submitTelemetry({ | ||
| points, | ||
| }: SubmitTelemetryRequest): Promise<SubmitTelemetryResponse> { | ||
| const api = new WebApi() |
There was a problem hiding this comment.
I just noticed we don't consistency configure this from somewhere to let us test against staging, or let other users point at their own endpoint.
NullSoldier
approved these changes
Feb 10, 2022
NullSoldier
force-pushed
the
feature/iro-1505
branch
from
03dce6d
to
83eace0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The existing telemetry implementation wasn't designed very intuitively. There was an existing
Telemetryinterface which was implemented byNodeTelemetryandDisabledTelemetry, each of which had a lot of side effects and returned new instances.This code change:
MetricandFieldfrom types to interfaces (inspired by TS docs)Testing Plan
Added unit tests and verified manually in InfluxDB for my
node_id.Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.