Migrate from deprecated cli-ux to @oclif/core #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great! We'll try to get this tested when we have some free time. Do you think you'll have the spare time to migrate the old packages to |
Yep, sure. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
cli-ux package is deprecated now. This PR contains migration from cli-ux to @oclif/core.
All changes were made by instructions from package migration manual.
Also, there are some other "old" @oclif/* packages in project (like @oclif/command, @oclif/config, etc). They all marked as "in maintenance mode" and replaced by @oclif/core. It's probably better to do their migration in another PR.
Testing Plan
Whole refactoring pretty transparent: import another namespace from new package and use it instead of old one. I tested every refactored command manually and ran
yarn testfor sure. All tests passed.Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.