Fix Issue #875

[wd021]

Localization error is causing languages that use , instead of . to break (ie de_DE). Applying "en-US" in toLocaleString() to prevent this error.

[Kupuyc]

Is it good approach - to hardcode locale? 🤔

Probably, it's better to use dotenv and set LC_ALL to "en_US.UTF8", "de_DE.UTF8", etc. Doing so we can test localized messages by equivalence classes.

Edit: fix typo.

[wd021]

Hardcoding because we're using en-US.UTF8 formatting for numerical displays.

Not sure what would be the need for setting de_DE.UTF8 or any other local format, it'd just fail the test. Unless we're localizing the whole app to account for different formats 🤷

[NullSoldier]

I think this is going to make people in non en-us countries very unhappy. What if we just make the test use toLocaleString() as well?

[wd021]

good point!

updated - tests now use toLocaleString().

[NullSoldier]

Looks good, will merge if tests pass.

[wd021]

@NullSoldier updated fix for lint issues.

[NullSoldier]

Can you base this off staging?

[wd021]

yes sir

[dguenther]

Looks good, thank you!