Remove napi-rs factory functions #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
napi-rs has a concurrency bug when constructing objects using factory functions in worker threads. This change removes the use of factory functions in favor of constructors.
dguenther
force-pushed
the
remove-napi-factory
branch
from
a006d07
to
d8c6318
Compare
mat-if
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
napi-rs has a concurrency bug when constructing objects using factory functions in worker threads. This change removes the use of factory functions in favor of constructors.
Testing Plan
Tested that syncing a chain from a clean database doesn't cause incorrect block verification errors. Other than that, the strategy tests should pass.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.