Remove enabled from telemetry #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already don't start the telemetry system it's not enabled so we can just simplify this to operate based off of the telemetry system is running or not.
NullSoldier
force-pushed
the
remove-enabled
branch
from
28d0fc3
to
8ab9894
Compare
rohanjadvani
approved these changes
Feb 10, 2022
NullSoldier
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We already don't start the telemetry system it's not enabled so we can
just simplify this to operate based off of the telemetry system is
running or not.
Testing Plan
Ran code
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.