Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve usability around telemetry #987

Merged
merged 3 commits into from Feb 12, 2022
Merged

Improve usability around telemetry #987

merged 3 commits into from Feb 12, 2022

Conversation

NullSoldier
Copy link
Contributor

@NullSoldier NullSoldier commented Feb 11, 2022 •
edited

Summary

Changes

  • Properly prints the right command to enable telemetry
  • Ties the code to a variable so that there will be a build error if
    the key changes
  • Make testnet command ask user to opt into telemetry

Other changes.

  • Optimize first run so it doesn't need to spin up the RPC layer just
    to set commands

> ironfish start

::::::::::          :::::::::::::::::
::::::::::::       :::::::::::::::::::
:::::::::::::     :::::::::::::::::::::
::::::::::::::   ::::::::::::::::::::::::
 ::::::::::::: ::::::::::        :::::::::
   :::::::::::::::::::::          ::::::::::
   :::::::::::::::::::::          :::::::::
 ::::::::::::: ::::::::::        :::::::::
::::::::::::::   ::::::::::::::::::::::::
:::::::::::::     :::::::::::::::::::::
::::::::::::       :::::::::::::::::::
::::::::::           ::::::::::::::::

Version       0.1.21 @ src
Node Name     JASON💪💎🚀
Graffiti      JASON💪💎🚀
Peer Identity LW8m+VUQGMkZ4JQ54HPqYkLtfv7TiVM7Bzfu9vMrcmw=
Peer Agent    ironfish-cli/0.1.21/src
Peer Port     9033
Bootstrap     test.bn1.ironfish.network


Thank you for installing the Iron Fish Node.

To help improve Ironfish, opt in to collecting telemetry by running
 > ironfish config:set enableTelemetry true

WebSocket server started at :::9033
Connected to the Iron Fish network

> ironfish testnet

Enter the user id or url to a testnet user like https://testnet.ironfish.network/users/1080
User ID or URL: 1080

Asking Iron Fish who user 1080 is...

Hello JASON💪💎🚀!

You are about to change your NODE NAME from {NOT SET} to JASON💪💎🚀
You are about to change your GRAFFITI from {NOT SET} to JASON💪💎🚀
Are you SURE? (y)es / (n)o: y

Do you want to help improve Ironfish by enabling Telemetry? (y)es / (n)o: y

✅ Updated NODE NAME from {NOT SET} to JASON💪💎🚀
✅ Updated GRAFFITI from {NOT SET} to JASON💪💎🚀
✅ Telemetry Enabled 🙏

Testing Plan

Ran commands to test

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.

[ ] Yes
[x] No

@NullSoldier NullSoldier requested a review from a team as a code owner February 11, 2022 00:46
deekerno
deekerno approved these changes Feb 11, 2022
View reviewed changes
ironfish-cli/src/commands/start.ts Outdated Show resolved Hide resolved
ironfish-cli/src/commands/testnet.ts Outdated Show resolved Hide resolved
@NullSoldier NullSoldier force-pushed the ux-fixes branch 3 times, most recently from 569dabb to d659ff3 Compare February 11, 2022 01:08
@dguenther dguenther force-pushed the ux-fixes branch 2 times, most recently from cbdec62 to 4617c2c Compare February 12, 2022 06:14
NullSoldier and others added 3 commits February 11, 2022 22:19
@NullSoldier @dguenther
Improve usability around telemetry
fde7738 
 - Properly prints the right command to enable telemetry
 - Ties the code to a variable so that there will be a build error if
   the key changes
 - Optimize first run so it doesn't need to spin up the RPC layer just
   to set commands
 - Make testnet command ask user to opt into telemetry
@dguenther
Fix test
a23aee8
@dguenther
Rebase on staging
c0009fd
@dguenther dguenther merged commit 239f9a4 into staging Feb 12, 2022
@dguenther dguenther deleted the ux-fixes branch February 12, 2022 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deekerno deekerno deekerno approved these changes

@dguenther dguenther dguenther approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NullSoldier @dguenther @deekerno