-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InputStream #75
InputStream #75
Conversation
if payload != "" | ||
puts "Received from STDIN: #{payload}" | ||
end | ||
|
||
# or using env vars: ENV['PAYLOAD'] | ||
payload = ENV['PAYLOAD'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will overwrite your STDIN.
Some comments.
|
AppName: appName, | ||
Stdout: &stdout, | ||
Stderr: &stderr, | ||
InputStream: string(payload), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is InputStream taking a string?
Needs rebase and description needs updating. |
|
||
log.WithField("payload", string(payload)).Debug("Got payload") | ||
// TODO: Print payload debug without cleaning the reader var. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we'll ever need to print this to the logs. Payload could be huge.
@pedronasser can you review this PR please, thanks. |
LGTM but needs to be resolved! |
squashed and resolved conflicts at #111! |
No description provided.