-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests are broken #86
Comments
I don't understand code in tests. Either rewrite them so they are readable or I can't fix them. |
what part don't you understand? |
all test-related code is messy and hard to read. also, most of the test doesn't test lib but underlying services. |
ok, then this one is messy and hard to read, too: https://github.com/iron-io/iron_worker_ruby_ng/blob/master/test/test_basic.rb |
ok, could you please point the line? |
and what is wrong with that? run cli, ensure log matches /Queued up.*"id":"(.{24})"/ so it have queued task and output smth that looks like id, match that id and use in next call |
I do not want to read regexps especially when they are not needed. |
/Queued up.*"id":"(.{24})"/ is not readable? sure? |
Better way - remove this assert. It relies on specific msg format returned by server and has nothing to do with lib it supposed to test. |
if I remove this assert, I'll need to remove all further asserts: they use task id I parse |
you only need to test that cli passed correct options to Code / Client. no need to queue even in this case. |
@iced can't hurt to go all the way through the process can it? Why wouldn't we do that? |
just because tests takes 15 to 30 mins on my local box now, so they are completely useless as I can't run them. |
we agreed (several times) that it is ok to involve service in ng test
|
@iced |
I'd prefer suite which tests lib itself and does it without queuing 100 workers just to test some unknown to me thing. |
@iced I'd prefer such suite, too
have you read it? |
personally I run
to run tests remotely, without test_batch |
|
|
do you mean you'll proceed to ignore tests? |
I tried to use them and still use them before release, but I only check if not MUCH of them fails. I never was able to make suite to run with 100% asserts passed. And don't make me start on test suite needing pry gem for yet another unknown for me reason. I have my own set of workers (like 10 of them) which I queue to check if everything works right. It takes like 20-30 seconds and tests as much as test suite itself. |
do I get it right?
|
|
they pass now. |
again
@iced could you please check they are not broken before commit?
The text was updated successfully, but these errors were encountered: