Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accounts-ui integration #74

Closed
patrickleet opened this issue Aug 23, 2013 · 3 comments
Closed

Accounts-ui integration #74

patrickleet opened this issue Aug 23, 2013 · 3 comments

Comments

@patrickleet
Copy link

I'm having trouble getting some of the accounts-ui package to work with iron-router. Specifically the "enroll account" and "reset password" links that are emailed.

The router seems to intercept this urls and redirect, which stops the modal from opening.

http://localhost:3000/#/reset-password/toTdop3rANDPfYbR6
http://localhost:3000/#/enroll-account/tn4GmhLTZM7FePHFK

@cmather
Copy link
Contributor

cmather commented Aug 23, 2013

Hey Patrick, this is a known issue but needs to be resolved soon. I'm about to get on a long plane ride so maybe that's a good time to dig into it. In the mean time, if you look in the Closed Issues, Sam H came up with a workaround by essentially creating new email routes and manually wiring them up.

Sent from my iPhone

On Aug 23, 2013, at 8:23 AM, Patrick Scott notifications@github.com wrote:

I'm having trouble getting some of the accounts-ui package to work with iron-router. Specifically the "enroll account" and "reset password" links that are emailed.

The router seems to intercept this urls and redirect, which stops the modal from opening.

http://localhost:3000/#/reset-password/toTdop3rANDPfYbR6
http://localhost:3000/#/enroll-account/tn4GmhLTZM7FePHFK


Reply to this email directly or view it on GitHub.

@cmather
Copy link
Contributor

cmather commented Aug 23, 2013

@patrickleet, I think this might be related to Issue #62 below which was fixed in the last release. The accounts-ui package renders the dialogs directly in the body (even though you can't see them yet), and the Router was wiping that out and replacing the body contents with its own stuff. The fix was to not wipe out the body but instead append to it.

If you update the iron-router to the latest version does that fix this issue?

#62
#3

@patrickleet
Copy link
Author

Thanks Chris, I'll look there for now

Sent from Mailbox for iPhone

On Fri, Aug 23, 2013 at 12:56 PM, Chris Mather notifications@github.com
wrote:

Hey Patrick, this is a known issue but needs to be resolved soon. I'm about to get on a long plane ride so maybe that's a good time to dig into it. In the mean time, if you look in the Closed Issues, Sam H came up with a workaround by essentially creating new email routes and manually wiring them up.
Sent from my iPhone
On Aug 23, 2013, at 8:23 AM, Patrick Scott notifications@github.com wrote:

I'm having trouble getting some of the accounts-ui package to work with iron-router. Specifically the "enroll account" and "reset password" links that are emailed.

The router seems to intercept this urls and redirect, which stops the modal from opening.

http://localhost:3000/#/reset-password/toTdop3rANDPfYbR6
http://localhost:3000/#/enroll-account/tn4GmhLTZM7FePHFK

Reply to this email directly or view it on GitHub.

Reply to this email directly or view it on GitHub:
#74 (comment)

@cmather cmather closed this as completed Aug 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants