Iron Request is missing/losing hyper Ssl

[MarkSwanson]

Hello,

My Iron handler must have access to hyper Request.Ssl.
I note that when Iron constructs its own Request struct that it forgets to also grab Ssl.
Is this on purpose (perhaps out of scope for Iron atm)?

(Iron src/request/mod.rs)

    pub fn from_http(req: HttpRequest<'a, 'b>, local_addr: SocketAddr, protocol: &Protocol)
                     -> Result<Request<'a, 'b>, String> {
        let (addr, method, headers, uri, _, reader) = req.deconstruct();

...

        Ok(Request {
            url: url,
            remote_addr: addr,
            local_addr: local_addr,
            headers: headers,
            body: Body::new(reader),
            method: method,
            extensions: TypeMap::new()
        })

Thanks!

[untitaker]

What information in particular do you want from Hyper's datastructures?

[sfackler]

@untitaker I believe the request is for a method that forwards to Request::downcast_ref: https://docs.rs/hyper/0.9.14/hyper/server/request/struct.Request.html#method.downcast_ref

[frjonsen]

I suspect this bug is due to this: https://github.com/iron/iron/blob/master/src/iron.rs#L137

When constructing a https server, Protocol::http() is used. This makes things like the iron-routers url_for! not work properly, because it constructs a http:// url even when using https.

[untitaker]

@frjonsen I think your bug is valid but not related to this issue

[frjonsen]

Ah, yes, I see now I went through the issue a bit quickly, as it seemed similar enough to the issue I was having. Sorry about that.

[untitaker]

Please create a new issue though

…

On 10 March 2017 12:04:28 CET, "Fredrik Jonsén" ***@***.***> wrote: Ah, yes, I see now I went through the issue a bit quickly, as it seemed similar enough to the issue I was having. Sorry about that. -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #425 (comment)

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.