(feat) Request and Response #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This may be an issue external to this PR, but types are coerced in Iron with no extensibility. The only choice for coerced types is, at this point, UPDATE: This is now documents as an issue, #14. |
|
Awesome. |
phlmn
pushed a commit
to phlmn/iron
that referenced
this pull request
Oct 19, 2018
(fix) Special cases empty routes to be "/" instead of ""
phlmn
pushed a commit
to phlmn/iron
that referenced
this pull request
Oct 19, 2018
(fix) Updated rust installation.
phlmn
pushed a commit
to phlmn/iron
that referenced
this pull request
Oct 19, 2018
(fix) Update Makefile/Travis for Cargo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds preliminary
RequestandResponsetraits, and default implementations.This currently relies on rust-http, which does not expose enough fields of the
ResponseWriterfor aClone-like implementation, so the implementations will need to be amended eventually.Specifically,
Responseis implemented as a synonym ofResponseWriter.