Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Update term to 0.4, use the new Result type #72

Closed
wants to merge 2 commits into from
Closed

(fix) Update term to 0.4, use the new Result type #72

wants to merge 2 commits into from

Conversation

mcasper
Copy link

@mcasper mcasper commented Jan 3, 2016

I've been having issues with logger and the Docker Ubuntu image where logger will cause the container to silently 500 to all requests, making both my app and me very sad.

Updating to term 0.3 (unreleased at the moment) and updating logger's code to use term's new error type fixes the issue.

Issue on term to get 0.3 released: Stebalien/term#51

@reem
Copy link
Member

reem commented Jan 5, 2016

Ok, we'll need to wait for term 0.3 to be released before I can merge this and make a new release. Looks good though.

@mcasper
Copy link
Author

mcasper commented Jan 5, 2016

Sounds good, I'll ping you whenever it gets released

@mcasper mcasper changed the title (fix) Update term to 0.3 (currently unreleased), use the new Error type (fix) Update term to 0.4, use the new Result type Jan 11, 2016
@mcasper
Copy link
Author

mcasper commented Jan 11, 2016

@reem Switched over to the official release of term 0.4 (apparently 0.3 was already out), so this should be good to go

@vegai vegai mentioned this pull request Jan 15, 2016
@mcasper
Copy link
Author

mcasper commented Jan 16, 2016

@reem bump

@ramn
Copy link

ramn commented Mar 2, 2016

+1

@reem
Copy link
Member

reem commented Jul 4, 2016

Hey, sorry for letting this stall. It appears this now has conflicts, if you can fix them I'd be glad to merge.

@SkylerLipthay
Copy link
Member

Just a heads up, #86 upgraded to term 0.4 but did not change the error type. I'm a bit confused at the underlying problem here... but if this fix is still necessary then there are newer conflicts to consider while updating this PR 💔

@Hoverbear
Copy link

Hey! So we're using term 0.4 now and it seems to be functioning. I'm going to close this. Feel free to re-open if it's still an issue.

@Hoverbear Hoverbear closed this Oct 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants