Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thrift module is dependent on ws module #1

Open
kessler opened this issue Sep 7, 2017 · 3 comments
Open

thrift module is dependent on ws module #1

kessler opened this issue Sep 7, 2017 · 3 comments
Assignees

Comments

@kessler
Copy link
Member

kessler commented Sep 7, 2017

the thrift module source is hosting on fsf git not on github, I'm not familiar with the procedure for submitting PRs and such but we might need to fork it to a non ws dependent version

@dominictarr
Copy link
Contributor

forking it would not be a problem because we just use the thrift module for parsing not networking, we just don't use that code.

@kessler
Copy link
Member Author

kessler commented Sep 11, 2017 via email

@asmuth
Copy link
Contributor

asmuth commented Nov 14, 2017

native deps (all optional/non-essential)

  • ws
  • brotli
  • snappy
  • lzo

jeffbski-rga pushed a commit to jeffbski/parquetjs that referenced this issue Mar 2, 2020
asmuth pushed a commit that referenced this issue Jun 16, 2020
Fix for bug that causes memory overrun and adds more rows than it should
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants