Various fixes and cleanups #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following plugin adds the META.json file. This is considered the more modern META data format.
The following plugin will add the provides metadata to the distribution, which is considered a best practice.
This, I assume, meant to be a shebang, but missing the bang. It's also useless because perl is called explicitly on tests, as well as none of the other tests havin a shebang.
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[This is part of my work on the Pull Request Challenge.]
This branch implements a set of fixes. Each commit includes a single fix with explanations on why it was done. I have another feature which awaits this and two other branches on DBICx-Sugar to be merged (which I will submit shortly). Think of it as "Step 1 out of 4".
The fixes, in summary, include:
META.jsonfile in the dist.providesentry in the metadata.