New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes and cleanups #19

Merged
merged 4 commits into from Feb 10, 2017

Conversation

Projects
None yet
2 participants
@xsawyerx
Contributor

xsawyerx commented Feb 10, 2017

[This is part of my work on the Pull Request Challenge.]

This branch implements a set of fixes. Each commit includes a single fix with explanations on why it was done. I have another feature which awaits this and two other branches on DBICx-Sugar to be merged (which I will submit shortly). Think of it as "Step 1 out of 4".

The fixes, in summary, include:

  • Provide META.json file in the dist.
  • Provide provides entry in the metadata.
  • Code cleanups.

xsawyerx added some commits Feb 10, 2017

Provide META.json file in distribution:
The following plugin adds the META.json file. This is considered
the more modern META data format.
Add provides metadata:
The following plugin will add the provides metadata to the
distribution, which is considered a best practice.
Cleanup: Remove useless comment:
This, I assume, meant to be a shebang, but missing the bang. It's
also useless because perl is called explicitly on tests, as well
as none of the other tests havin a shebang.

@xsawyerx xsawyerx changed the title from Sawyer/fixes to Various fixes and cleanups Feb 10, 2017

@ironcamel

This comment has been minimized.

Show comment
Hide comment
@ironcamel

ironcamel Feb 10, 2017

Owner

Thanks.

Owner

ironcamel commented Feb 10, 2017

Thanks.

@ironcamel ironcamel merged commit 5adc080 into ironcamel:master Feb 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment