Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System.ArgumentOutOfRangeException when trying to open certain invalid files #38

Closed
Numpsy opened this issue Jan 8, 2019 · 1 comment
Closed

System.ArgumentOutOfRangeException when trying to open certain invalid files #38

Numpsy opened this issue Jan 8, 2019 · 1 comment
Assignees
@ironfede
Labels
bug

Comments

@Numpsy
Copy link
Contributor

Numpsy commented Jan 8, 2019

Hi,
Not sure what the official situation is with exception types, but for what it's worth, both of the files in the attached ArgumentOutOfRangeException.zip cause a System.ArgumentOutOfRangeException to be thrown if you try to load them with OpenMCDF, was wondering if that should really be a CFCorruptedFileException or CFException or some such?
ironfede added a commit that referenced this issue Jan 8, 2019
@ironfede
Fix for #38 - Added handling of empty sector chain/no sector cases
3e66664
@ironfede ironfede self-assigned this Jan 8, 2019
@ironfede ironfede added the bug label Jan 8, 2019
@ironfede
Copy link
Owner

ironfede commented Jan 8, 2019

Fixed in current main branch.
Added CFCorruptedException and CFException wrappers for uploaded cases.
Thank you @Numpsy

@ironfede ironfede closed this as completed Jan 8, 2019
@Numpsy Numpsy mentioned this issue Jan 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ironfede ironfede

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Numpsy @ironfede