Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protection in DsXmlDeployer to prevent from loading xml resource … #576

Merged

Conversation

tcollignon
Copy link
Contributor

…in jar file, and add possibility of override this class

As I have done in #559 , I propose this PR to do exactly the same thing for DsXmlDeployer.

My goal is to allow a custom DsXmlDeployer file who Override DsXmlDeployer and manage xml datasource loacted in jar file.

Copy link
Member

@maeste maeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to open a jira in issue.jboss.org and use the jira number in your commit comment.
You should also sign https://cla.jboss.org/index.seam if you haven't done yet

@tcollignon
Copy link
Contributor Author

Hi

Ok I have open this : https://issues.jboss.org/browse/JBJCA-1333
Is it ok ?

I have try to subscribre in https://cla.jboss.org/index.seam in "jboss tools" category, is it the good one? (I don't see ironjacamar)

Thanks

@maeste
Copy link
Member

maeste commented Sep 26, 2016

Issue is ok. Please reword your commit comment and push -f your branch.

Sign CLA under "JBoss Application Server" please.

Thanks again
S.

…xml resource in jar file, and add possibility of override this class
@tcollignon tcollignon force-pushed the dev_1.2_dsxmldeployer_protect_from_jar branch from 97ed6b7 to a2aec6b Compare September 26, 2016 15:16
@tcollignon
Copy link
Contributor Author

Ok I have reword my commit
and I have sign to Jboss Application Server

@maeste maeste merged commit e5cd1a6 into ironjacamar:1.2 Sep 27, 2016
@tcollignon
Copy link
Contributor Author

Thank you !

Have you cherry-pick this on 1.3 too ?

Thanks again

@maeste
Copy link
Member

maeste commented Sep 27, 2016

No yet, feel free do it yourself submitting another PR ;)

@tcollignon
Copy link
Contributor Author

Ok no problem (last time you do this, that's why I ask)
I need to make another issue or I sumbit with the same number?
Thanks

@maeste
Copy link
Member

maeste commented Sep 27, 2016

The same issue is fine, just cherry pick the commit.
I'm asking you just to give you more kudos in the project / github
Regards
S.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants