New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add protection in DsXmlDeployer to prevent from loading xml resource … #576
Add protection in DsXmlDeployer to prevent from loading xml resource … #576
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to open a jira in issue.jboss.org and use the jira number in your commit comment.
You should also sign https://cla.jboss.org/index.seam if you haven't done yet
Hi Ok I have open this : https://issues.jboss.org/browse/JBJCA-1333 I have try to subscribre in https://cla.jboss.org/index.seam in "jboss tools" category, is it the good one? (I don't see ironjacamar) Thanks |
Issue is ok. Please reword your commit comment and push -f your branch. Sign CLA under "JBoss Application Server" please. Thanks again |
…xml resource in jar file, and add possibility of override this class
97ed6b7
to
a2aec6b
Compare
Ok I have reword my commit |
Thank you ! Have you cherry-pick this on 1.3 too ? Thanks again |
No yet, feel free do it yourself submitting another PR ;) |
Ok no problem (last time you do this, that's why I ask) |
The same issue is fine, just cherry pick the commit. |
…in jar file, and add possibility of override this class
As I have done in #559 , I propose this PR to do exactly the same thing for DsXmlDeployer.
My goal is to allow a custom DsXmlDeployer file who Override DsXmlDeployer and manage xml datasource loacted in jar file.