Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Alpine Linux for Docker Builds #40

Closed
wants to merge 2 commits into from

Conversation

gthole
Copy link
Contributor

@gthole gthole commented Dec 31, 2021

Hello! Exploring euterpe and considering the possibility of adopting it for my personal music server. I thought I'd contribute a small change in return.

I suggest switching to alpine linux in the Dockerfile.

This results in:

  • Smaller image sizes
  • More secure application environment
  • Only use packages required for build

Thanks so much!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1641203785

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 80.858%

Files with Coverage Reduction New Missed Lines %
src/library/database.go 4 78.95%
src/library/local_library.go 4 77.47%
Totals Coverage Status
Change from base Build 1377746862: -0.2%
Covered Lines: 3109
Relevant Lines: 3845

💛 - Coveralls

@ironsmile
Copy link
Owner

Good idea, thank you! I too prefer Alpine lately and it is only inertia which kept Debian in play here.

Dockerfile Outdated Show resolved Hide resolved
@ironsmile
Copy link
Owner

Thank you for the suggestion! ♥ It has been added to master already with 32ce53d and 22f9aed. I am closing this PR.

On the next release the published Docker hub image will be using Alpine 🎉

@ironsmile ironsmile closed this Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants