Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get context from request #222

Merged
merged 4 commits into from
Dec 27, 2016
Merged

Get context from request #222

merged 4 commits into from
Dec 27, 2016

Conversation

mstoykov
Copy link
Collaborator

No description provided.

@mstoykov
Rename RequstHandler.RequestHandle to ServeHTTP
1b76798
@mstoykov
Replace custom request handler with http.Handler
62dd75e 
This includes removing the old style of sending context.Context with
each request as first argument but not actually using the context
provided by the net/http.
@mstoykov
Drop 1.6.4 support in travis
93cf422
@coveralls
Copy link

coveralls commented Dec 27, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 71.461% when pulling 93cf422 on getContextFromRequest into 97e21b0 on master.

@coveralls
Copy link

coveralls commented Dec 27, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 71.461% when pulling 67b1e50 on getContextFromRequest into 2f16f9b on master.

ironsmile
ironsmile approved these changes Dec 27, 2016
View reviewed changes
Copy link
Owner

@ironsmile ironsmile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is much simpler now! Tell me that the renaming from RequestHandler to http.Handler was possible with gorename!

@mstoykov
Copy link
Collaborator Author

Nope, both RequstHandle -> ServeHTTP and RequestHandler -> http.Handler were done with sed :D

@mstoykov mstoykov merged commit 01acf83 into master Dec 27, 2016
@mstoykov mstoykov deleted the getContextFromRequest branch December 27, 2016 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ironsmile ironsmile ironsmile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mstoykov @coveralls @ironsmile