Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use pageX vs. clientX #1

Open
awirick opened this issue Jun 20, 2013 · 0 comments
Open

use pageX vs. clientX #1

awirick opened this issue Jun 20, 2013 · 0 comments

Comments

@awirick
Copy link
Contributor

awirick commented Jun 20, 2013

clientX/clientY will fail if a user is scrolled. pageX/pageY seem better here. layersX/layersY looks like it would also work. PR coming.

Considering using relative position within the chart area and using offsetX/offsetY for positioning instead. Make more sense, or is there a reason not to go for that? Perhaps an option-able feature...
awirick added a commit to awirick/d3.chart.tooltips that referenced this issue Jun 20, 2013
@awirick
fixes issue iros#1.
5106c8e
iros added a commit that referenced this issue Sep 4, 2013
@iros
Merge pull request #2 from awirick/issue_pagex
47f9c77 
fixes issue #1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@awirick