Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wide open version ranges will probably break #17

Closed
dominictarr opened this issue Oct 13, 2014 · 3 comments
Closed

wide open version ranges will probably break #17

dominictarr opened this issue Oct 13, 2014 · 3 comments

Comments

@dominictarr
Copy link

This is a dangerous:
https://github.com/coolbloke1324/ForerunnerDB/blob/master/package.json#L7-L11

Sooner or later someone will publish a new version of these modules, and since
you always get the latest, you'll get that, but it might have changed since you wrote
this module.

In npm you should always set the major version at the very least, because that is
(following semver.org) used to designate breaking changes. The easiest way
is to use the npm install {module} --save and then it will keep the package.json up to date for you.

@Irrelon
Copy link
Owner

Irrelon commented Oct 13, 2014

Hey thanks. Already dealt with in Dev branch. :)
On 13 Oct 2014 21:53, "Dominic Tarr" notifications@github.com wrote:

This is a dangerous:

https://github.com/coolbloke1324/ForerunnerDB/blob/master/package.json#L7-L11

Sooner or later someone will publish a new version of these modules, and
since
you always get the latest, you'll get that, but it might have changed
since you wrote
this module.

In npm you should always set the major version at the very least, because
that is
(following semver.org) used to designate breaking changes. The easiest way
is to use the npm install {module} --save and then it will keep the
package.json up to date for you.


Reply to this email directly or view it on GitHub
#17.

@dominictarr
Copy link
Author

great, btw, have you seen the level-* stuff on npm? there is loads of stuff that has been done creating databases in node - generally on top of leveldb, but also on top of things like indexeddb - normally via wrappers such as: https://github.com/maxogden/level.js the starting point was https://github.com/rvagg/node-levelup

@pmxrob
Copy link
Collaborator

pmxrob commented Oct 14, 2014

@dominictarr Hey, no I hadn't seen that stuff. Interesting, thanks for the link, I'll take a look when I've got a sec! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants