Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix auto trait impl Send and Sync #22

Merged
merged 1 commit into from Nov 28, 2023
Merged

fix auto trait impl Send and Sync #22

merged 1 commit into from Nov 28, 2023

Conversation

zzau13
Copy link
Contributor

@zzau13 zzau13 commented Oct 30, 2022

Fixes #21

@jjl
Copy link
Contributor

jjl commented Oct 31, 2022

i'll merge it if you like, but there's a bigger issue with the atomics i've just been unmotivated to work on. i'm a bit surprised people are still using this actually, maybe i should yank it til i get around to fixing it.

@zzau13
Copy link
Contributor Author

zzau13 commented Oct 31, 2022

I was just testing. I've read. Where I am using it it seems to work fine. Can you tell me a little more about this issue and I'll try to solve it.

@jjl
Copy link
Contributor

jjl commented Oct 31, 2022

It looks like i already started to refactor it a bit on my local copy. As it happens i have some paperwork to procrastinate this morning, so i'll have another go 😅

@zzau13
Copy link
Contributor Author

zzau13 commented Oct 31, 2022

Thank you very much, if you need anything do not hesitate to tell me. Good luck with the refactor.

@jjl
Copy link
Contributor

jjl commented Oct 31, 2022

I put in some time, but my brain isn't really there and i have to figure out which of the handful of approaches that occurred to me today to choose.

But i'll try and do some more on it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send Sender/Reciever<T> needs T: Sync
3 participants