Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TLS flag not reset during connection attempts #1027

Closed
GyrosGeier opened this issue Mar 27, 2019 · 0 comments · Fixed by #1134
Closed

TLS flag not reset during connection attempts #1027

GyrosGeier opened this issue Mar 27, 2019 · 0 comments · Fixed by #1134
Labels
bug tls z-affects-1.2.2
Milestone
1.2.3

Comments

@GyrosGeier
Copy link

GyrosGeier commented Mar 27, 2019 •
edited

I have a TLS and a non-TLS server in the same rotation:

eu.irc6.net          6667  IRCnet     tls
irc.in.tum.de        6667  IRCnet

When I use /connect IRCnet while not connected to a v6 capable net, I get a connection error trying to reach the v6 server, and then a TLS protocol error from the other server, even though that doesn't have a tls flag. If I interrupt with /rmreconns and give a new /connect IRCnet command, it works if the first server it tries is the non-TLS server, so it seems that the tls flag is stuck between connection attempts.

This is irssi 1.0.7 as found in Debian stable and 1.2.0 as found in Debian stable-backports.
horgh added a commit to horgh/irssi that referenced this issue Oct 12, 2019
@horgh
Do not copy TLS settings to reconnection record
1639425 
This was causing us to use the TLS settings from one server on another
which is not always appropriate. Instead, we now treat it like other
connection information and do not copy it. We get the TLS settings later
as appropriate when connecting.

Note there is still probably more that could be cleaned up here. For
example, the unix socket might be better treated as connection info too.

Fixes irssi#1027.
@horgh horgh mentioned this issue Oct 12, 2019
Merged
@ailin-nemui ailin-nemui mentioned this issue Mar 25, 2020
Closed
@ailin-nemui ailin-nemui added this to the 1.2.3 milestone Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug tls z-affects-1.2.2
Projects
None yet
Milestone
1.2.3
Development

Successfully merging a pull request may close this issue.

Use correct TLS settings when reconnecting horgh/irssi
2 participants
@ailin-nemui @GyrosGeier