Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure automake with nostdinc #1268

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Conversation

ailin-nemui
Copy link
Contributor

@ailin-nemui ailin-nemui commented Feb 1, 2021

the current directory won't be added to the compiler's -I path

the current directoryh won't be added to the compiler's -I path
@ailin-nemui
Copy link
Contributor Author

this makes the build closer to meson. also it means #include <term.h> shouldn't include Irssi's own term.h in #1267

@ailin-nemui ailin-nemui added the auto-merge This PR is scheduled for merge if no further comments are opened label Feb 3, 2021
@ailin-nemui
Copy link
Contributor Author

@irssi/developers

@dequis
Copy link
Member

dequis commented Feb 3, 2021

Did you check if this affects known modules? (Should probably include it in release notes as potentially breaking anyway)

@ailin-nemui
Copy link
Contributor Author

as it is only our own compilation, this should not be able to affect 3rd party modules in any way :-)

Copy link
Member

@dequis dequis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh okay I assumed it'd stop people from #including things in certain ways

@ailin-nemui ailin-nemui merged commit 95f131d into irssi:master Feb 3, 2021
@ailin-nemui ailin-nemui deleted the nostdinc branch February 3, 2021 16:46
ailin-nemui added a commit that referenced this pull request Apr 8, 2021
configure automake with nostdinc

(cherry picked from commit 95f131d)
@ailin-nemui ailin-nemui added this to the 1.2.3 milestone Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge This PR is scheduled for merge if no further comments are opened z-affects-1.2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants