-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use glob matching for activity_hide_targets #437
Conversation
char **tmp; | ||
int index; | ||
|
||
g_return_val_if_fail(array != NULL, 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hrm, to be honest it might be better to return -1
instead of 0 to follow the return index of
item' in array' or -1 if not found
principle.
(This also applies to strarray_find
)
This deserves a mention in the docs. |
spaces vs tabs! strarray_find* needs to return -1 if no index found
From
and Glib's documentation
With the attached patch you have no way to reference a channel containing a |
it may have unfortunate consequences if you want to ignore activity in the channel #* |
Ah, thanks, yes, we don't want that, maybe we can just skip the matching if /Jari
|
I think this is fine now, @LemonBoy ? |
Use glob matching for activity_hide_targets
No description provided.