Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quote around macro argument #344

Merged
merged 1 commit into from
Oct 30, 2015
Merged

Commits on Oct 28, 2015

  1. Fix quote around macro argument

    In m4/curses.m4, line 134, the 5th argument passed to AC_NCURSES was
    surrounded by '"' instead of '[' and ']'. Because of that, the expansion
    of AC_NCURSES in that case would produce the following line inside the
    configure script (note the repeated double quotes):
    
      screen_manager=""ncurses on $withval/include""
    
    That would cause the following error when configure was executed with
    the "--with-ncurses=dir" argument:
    
      ./configure: line 13468: on: command not found
    
    Although in the case above the error doesn't actually influence the
    build process ('screen_manager' isn't used anywhere in the script),
    trying to execute 'on' might be harmful if it corresponded to an
    existing command in the user's environment.
    rrebello committed Oct 28, 2015
    Configuration menu
    Copy the full SHA
    06bf25b View commit details
    Browse the repository at this point in the history