Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow the XDG specification. #511

Closed
wants to merge 1 commit into from
Closed

Conversation

LemonBoy
Copy link
Member

@LemonBoy LemonBoy commented Jul 9, 2016

We're still 100% backward-compatible.

Supersedes #51, we now default to ~/.config/irssi if and only if it exists, otherwise ~/.irssi is used as before.

@dequis
Copy link
Member

dequis commented Jul 9, 2016

👎. Quoting previous rejected PR:

Also, given users often need to know where the Irssi directory is (e.g. to add scripts) I think adding an alternate location is just going to make it confusing

And

In general I don't think the cost of this is worth it. (Remember Irssi has users who are not hugely familiar with Unix and use this on a shell account; the cost of making a change and then obsoleting random tutorials on the web is very large).

We're still 100% backward-compatible.
@ailin-nemui
Copy link
Contributor

ailin-nemui commented Jul 12, 2016

scripts have to be in $XDG_DATA_DIR and so on...
I don't feel like your PR addresses any of the issues raised in the other issue

@LemonBoy
Copy link
Member Author

I took a simpler approach and jumped over all the bikeshedding, let's consider scripts as part of the configuration itself and have everything in ~/.config, let's not be so strict.

@dequis
Copy link
Member

dequis commented Jul 12, 2016

Well, no one said it explicitly, but the commit that happened after my comment changed the meaning of this PR, and it's less awful regarding backwards compatibility.

+       /* Try the XDG-compliant path first, if the config directory
+        * exists use it instead of the one at ~/.irssi */

I'm still not very enthusiastic about this whole thing. But at least it doesn't "break" new installs.

let's consider scripts as part of the configuration itself and have everything in ~/.config, let's not be so strict

I do like this mindset

@ailin-nemui
Copy link
Contributor

in my opinion we should either have a fully compliant solution with scripts in .local/share/irssi/scripts and maybe a new autorun concept or no XDG

@Earnestly
Copy link

Earnestly commented Oct 21, 2016

So many good ideas are never heard from again once they embark in a voyage on the semantic gulf.
— 53

@dequis
Copy link
Member

dequis commented Oct 22, 2016

@Earnestly Some ideas are also bad.

@ailin-nemui
Copy link
Contributor

I'll closse this for now, either a complete implementation or none. also voted by @dequis

ayham-1 added a commit to ayham-1/irssi that referenced this pull request Jan 6, 2021
- config file XDG support inspired from irssi#511
- added support to try loading scripts from XDG_DATA_HOME, if not present try
  loading from XDG_CONFIG_HOME, if not present try loading the usual way.
@ayham-1 ayham-1 mentioned this pull request Jan 6, 2021
ayham-1 added a commit to ayham-1/irssi that referenced this pull request Jan 6, 2021
- config file XDG support inspired from irssi#511
- added support to try loading scripts from XDG_DATA_HOME, if not present try
  loading from XDG_CONFIG_HOME, if not present try loading the usual way.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants