Added HIDDEN level to ignores #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The testing I did worked well but I might've missed something |
ailin-nemui
reviewed
Jun 6, 2018
src/core/ignore.h
Outdated
| @@ -29,6 +29,7 @@ int ignore_check(SERVER_REC *server, const char *nick, const char *host, | |||
| enum { | |||
| IGNORE_FIND_PATTERN = 0x01, /* Match the pattern */ | |||
| IGNORE_FIND_NOACT = 0x02, /* Exclude the targets with NOACT level */ | |||
| IGNORE_FIND_HIDDEN = 0x03, /* Exclude the targets with HIDDEN level */ | |||
There was a problem hiding this comment.
this should be 0x04 (bits go like 1 2 4 8 0x10 0x20 0x40...)
ailin-nemui
reviewed
Jun 6, 2018
src/fe-common/core/fe-ignore.c
Outdated
| @@ -157,7 +157,8 @@ static void cmd_ignore(const char *data) | |||
| g_strsplit(chanarg, ",", -1); | |||
|
|
|||
| rec = ignore_find_full(servertag, mask, patternarg, channels, | |||
| IGNORE_FIND_PATTERN | ((level & MSGLEVEL_NO_ACT) ? IGNORE_FIND_NOACT : 0)); | |||
| IGNORE_FIND_PATTERN | ((level & MSGLEVEL_NO_ACT) ? IGNORE_FIND_NOACT : 0) | | |||
There was a problem hiding this comment.
this is getting too ugly, we should add a temp variable flags= IGNORE_FIND_PATTERN and ...if (level &...) flags |= ...;
|
I would prefer making the #define ignore_match_level into a function too, but it didn't become too ugly when I added hidden to it |
|
I think what would help there is a |
|
@irssi/developers |
ailin-nemui
added
the
auto-merge
|
What does this do? |
|
I think it allows you to /ignore ..... hidden and then it will hide the messages instead of ignoring them completely |
|
Indeed
…On Thu, Jun 7, 2018, 16:11 ailin-nemui ***@***.***> wrote:
I think it allows you to /ignore ..... hidden and then it will hide the
messages instead of ignoring them completely
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#884 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AHqGLo9XuMcUXh-FIP7GdTnGPoXXwB8aks5t6TR1gaJpZM4UcGfE>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.