Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show output of git describe as PACKAGE_VERSION #988

Merged
merged 1 commit into from
Jan 16, 2019
Merged

show output of git describe as PACKAGE_VERSION #988

merged 1 commit into from
Jan 16, 2019

Conversation

ailin-nemui
Copy link
Contributor

also fixes GNUism in sed call

reported by Zed`

@ailin-nemui
show output of git describe as PACKAGE_VERSION
b8cfd9d 
also fixes GNUism in sed call
@dwfreed
Copy link
Member

dwfreed commented Jan 9, 2019

Note that this changes PACKAGE_VERSION from 1.2-gc7ce0f32 to 1.2-dev-320-gc7ce0f32

@ailin-nemui
Copy link
Contributor Author

on bsd it would incorrectly show 1.2-1.2-dev-320-gc7ce0f32 due to the lack of \+ support. I think showing it like this would be fine and even more insightful

@ailin-nemui
Copy link
Contributor Author

@irssi/developers

@ailin-nemui ailin-nemui added the auto-merge This PR is scheduled for merge if no further comments are opened label Jan 14, 2019
@ailin-nemui ailin-nemui merged commit 9ec2c8c into irssi:master Jan 16, 2019
@ailin-nemui ailin-nemui deleted the version branch February 11, 2019 17:13
@ailin-nemui ailin-nemui added this to the 1.2.0 milestone Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-merge This PR is scheduled for merge if no further comments are opened
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ailin-nemui @dwfreed